Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for CompleteTasks #6051

Merged

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented May 23, 2024

What changed?

  • Unit tests for CompleteTasks
  • Unit tests for CompleteTasksLessThan

Why?
Increase coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 018faa93-0656-487c-af1a-f68af9c95d35

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 61 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.008%) to 69.468%

Files with Coverage Reduction New Missed Lines %
service/matching/tasklist/db.go 2 73.23%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
service/history/task/transfer_standby_task_executor.go 4 87.24%
service/matching/tasklist/matcher.go 4 88.66%
service/history/task/fetcher.go 4 86.08%
common/task/fifo_task_scheduler.go 7 82.47%
service/matching/tasklist/task_reader.go 11 75.07%
Totals Coverage Status
Change from base Build 018faa62-bb7e-4a04-89d5-ced9d0d49d30: 0.008%
Covered Lines: 102409
Relevant Lines: 147418

💛 - Coveralls

@jakobht jakobht force-pushed the no_sql_task_store_test_CompleteTask branch from db1d7e1 to 713e899 Compare May 24, 2024 09:03
@jakobht jakobht force-pushed the no_sql_task_store_test_CompleteTask branch from 713e899 to dfe581c Compare May 24, 2024 12:28
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (edc5880) to head (dfe581c).

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc5880...dfe581c. Read the comment docs.

@jakobht jakobht merged commit 346d753 into cadence-workflow:master May 24, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants