Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made execution.Cache an interface so we can mock it in unit tests #6058

Merged
merged 2 commits into from
May 24, 2024

Conversation

jakobht
Copy link
Member

@jakobht jakobht commented May 24, 2024

What changed?
Made execution cache an interface

Why?
Now we can mock it in unit tests

How did you test it?
Unit and integration tests

Potential risks
Touches a lot of files but should be a safe change

Release notes

Documentation Changes

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (fc6fae5) to head (36d7881).
Report is 4 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/history/decision/handler.go 94.93% <ø> (ø)
...ervice/history/engine/engineimpl/history_engine.go 83.67% <ø> (ø)
service/history/execution/cache.go 37.24% <100.00%> (ø)
service/history/ndc/activity_replicator.go 85.36% <ø> (ø)
service/history/ndc/history_replicator.go 17.13% <ø> (ø)
service/history/ndc/transaction_manager.go 72.81% <ø> (ø)
...ice/history/queue/cross_cluster_queue_processor.go 39.13% <ø> (ø)
...istory/queue/cross_cluster_queue_processor_base.go 45.99% <ø> (ø)
service/history/queue/factory.go 100.00% <ø> (ø)
service/history/queue/timer_queue_processor.go 24.57% <ø> (ø)
... and 12 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6fae5...36d7881. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018faa8e-f44b-401a-8913-73e52eda9615

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 87 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.02%) to 69.441%

Files with Coverage Reduction New Missed Lines %
service/history/shard/context.go 2 68.99%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/task/fifo_task_scheduler.go 2 85.57%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.46%
service/history/task/transfer_standby_task_executor.go 4 86.63%
Totals Coverage Status
Change from base Build 018faa62-bb7e-4a04-89d5-ced9d0d49d30: -0.02%
Covered Lines: 102369
Relevant Lines: 147418

💛 - Coveralls

@jakobht jakobht merged commit 8d5c056 into cadence-workflow:master May 24, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…dence-workflow#6058)

What changed?
Made execution cache an interface

Why?
Now we can mock it in unit tests

How did you test it?
Unit and integration tests

Potential risks
Touches a lot of files but should be a safe change

Release notes

Documentation Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants