Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: make show,list workflow looks better #606

Merged
merged 8 commits into from
Mar 23, 2018
Merged

CLI: make show,list workflow looks better #606

merged 8 commits into from
Mar 23, 2018

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Mar 12, 2018

  1. Add color 2. remove datetime by default, can add using -pdt (print date time) flag

screen shot 2018-03-12 at 11 45 29 am

screen shot 2018-03-12 at 11 42 38 am

@vancexu vancexu requested a review from mfateev March 12, 2018 18:50
@vancexu
Copy link
Contributor Author

vancexu commented Mar 12, 2018

Change list cmd default to print one page (default 10 items)
Output in table and color
screen shot 2018-03-12 at 4 27 22 pm
screen shot 2018-03-12 at 4 27 37 pm

@vancexu vancexu changed the title CLI: make show workflow looks better CLI: make show,list workflow looks better Mar 12, 2018
@mfateev
Copy link
Contributor

mfateev commented Mar 12, 2018

I think for the list we want to print one page per default. But if flag is specified just stream all the pages (with appropriate throttling). But if someone does

cadence workflow list -m|more

then block pagination when buffer is full. See http://www.pixelbeat.org/programming/stdio_buffering/

@mfateev
Copy link
Contributor

mfateev commented Mar 13, 2018

Can we use shorter timestamps by default?
For show I would include only hours and seconds by default.

@vancexu
Copy link
Contributor Author

vancexu commented Mar 13, 2018

@mfateev I see what you mean. Note currently open/close worklfows can not be grabbed as stream, but as page.
The major difference between what you describe and my currently implementation is: you have a stream somewhere and then a "big" buffer so user can see a lot items each time they press button; but my is some number of items in one page (default 10), and user may need to press many times.
I can change the -m mode default using large page size 100, but then user cannot use their own page size (with -pagesize flag) for more mode. How does this sound to you? I personally prefer the current way

For shorter timestamps, what's your proposal? only time without date? I agree them take spaces but have not better way to deal with it.

@coveralls
Copy link

coveralls commented Mar 21, 2018

Coverage Status

Coverage decreased (-0.5%) to 63.679% when pulling fc75eb8 on cli into bdeb6d4 on master.

@vancexu
Copy link
Contributor Author

vancexu commented Mar 21, 2018

Add command listall, so that user can use pipe or redirect likecadence workflow listall | more

@vancexu vancexu merged commit 115a38a into master Mar 23, 2018
@vancexu vancexu deleted the cli branch March 23, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants