Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to execution manager #6074

Conversation

3vilhamster
Copy link
Member

What changed?
I've introduced more test to execution manager.

Side note: changed how history event itema re copied to avoid extra allocation.

Why?
Improving unit test coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

@3vilhamster 3vilhamster enabled auto-merge (squash) May 31, 2024 12:00
@3vilhamster 3vilhamster merged commit eaa93b1 into cadence-workflow:master May 31, 2024
18 checks passed
@3vilhamster 3vilhamster deleted the execution-manager-TestListConcreteExecutions branch May 31, 2024 12:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fce80-b408-43f6-8dda-e79137af6338

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 54 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.008%) to 69.644%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.28%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/persistence/execution_manager.go 2 90.22%
common/task/fifo_task_scheduler.go 2 85.57%
common/util.go 2 91.78%
service/matching/tasklist/task_writer.go 2 82.63%
common/persistence/statsComputer.go 2 97.14%
service/matching/tasklist/task_reader.go 2 77.45%
service/history/task/transfer_standby_task_executor.go 3 87.96%
service/history/task/task.go 3 84.81%
Totals Coverage Status
Change from base Build 018fcd8a-6d92-406f-9861-fe59d0f7e5a7: 0.008%
Covered Lines: 102981
Relevant Lines: 147868

💛 - Coveralls

timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants