Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DrainBacklogNoPollersIsolationGroup tests #6080

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Jun 1, 2024

What changed?
Fix DrainBacklogNoPollersIsolationGroup tests

Why?
The tests are flaky because we're not using the same timeSource across different components, and this makes some tasks expire and the tests never end.

How did you test it?
existing tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.22%. Comparing base (c6a145d) to head (8efefd1).

Additional details and impacted files
Files Coverage Δ
service/matching/tasklist/task_list_manager.go 63.70% <100.00%> (ø)
service/matching/tasklist/task_reader.go 73.80% <100.00%> (+0.68%) ⬆️
common/cache/lru.go 84.97% <80.00%> (+0.26%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a145d...8efefd1. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fd4cd-8372-4140-b2cf-697a6f7bac87

Details

  • 30 of 30 (100.0%) changed or added relevant lines in 5 files are covered.
  • 59 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.03%) to 69.658%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/persistence/execution_manager.go 2 90.46%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/replication/task_processor.go 2 81.25%
service/history/execution/mutable_state_util.go 2 78.52%
common/membership/hashring.go 2 84.69%
common/persistence/statsComputer.go 2 98.57%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
Totals Coverage Status
Change from base Build 018fd17e-a401-4eba-8372-591d1e581574: -0.03%
Covered Lines: 103050
Relevant Lines: 147937

💛 - Coveralls

Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Shaddoll Shaddoll merged commit f0f7efd into cadence-workflow:master Jun 3, 2024
20 checks passed
@Shaddoll Shaddoll deleted the matching-test branch June 3, 2024 16:25
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants