Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for RespondActivityTaskFailedByID in frontend API handler #6091

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add unit tests for RespondActivityTaskFailedByID in frontend API handler #6091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 135 additions & 0 deletions service/frontend/api/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ type (
mockHistoryArchiver *archiver.HistoryArchiverMock
mockVisibilityArchiver *archiver.VisibilityArchiverMock
mockVersionChecker *client.VersionCheckerMock
mockTokenSerializer *common.MockTaskTokenSerializer

testDomain string
testDomainID string
Expand Down Expand Up @@ -119,6 +120,7 @@ func (s *workflowHandlerSuite) SetupTest() {
s.mockVisibilityMgr = s.mockResource.VisibilityMgr
s.mockArchivalMetadata = s.mockResource.ArchivalMetadata
s.mockArchiverProvider = s.mockResource.ArchiverProvider
s.mockTokenSerializer = common.NewMockTaskTokenSerializer(s.controller)

s.mockProducer = &mocks.KafkaProducer{}
s.mockMessagingClient = mocks.NewMockMessagingClient(s.mockProducer, nil)
Expand Down Expand Up @@ -2010,6 +2012,139 @@ func (s *workflowHandlerSuite) newConfig(dynamicClient dc.Client) *frontendcfg.C
return config
}

func (s *workflowHandlerSuite) TestRespondActivityTaskFailedByID() {
config := s.newConfig(dc.NewInMemoryClient())
config.EnableClientVersionCheck = dc.GetBoolPropertyFn(true)
wh := NewWorkflowHandler(s.mockResource, config, s.mockVersionChecker, nil)
wh.tokenSerializer = s.mockTokenSerializer

validRequest := &types.RespondActivityTaskFailedByIDRequest{
Domain: s.testDomain,
WorkflowID: testWorkflowID,
RunID: testRunID,
ActivityID: "activityID",
Identity: "identity",
Details: make([]byte, 1000),
}

testInput := map[string]struct {
request *types.RespondActivityTaskFailedByIDRequest
expectError bool
mockFn func()
}{
"shutting down": {
request: validRequest,
mockFn: func() {
wh.shuttingDown = int32(1)
},
expectError: true,
},
"nil request": {
request: nil,
mockFn: func() {},
expectError: true,
},
"empty domain": {
request: &types.RespondActivityTaskFailedByIDRequest{
Domain: "",
},
mockFn: func() {},
expectError: true,
},
"cannot get domain ID": {
request: validRequest,
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return("", errors.New("error getting domain ID"))
},
expectError: true,
},
"empty domain ID": {
request: &types.RespondActivityTaskFailedByIDRequest{
Domain: s.testDomain,
WorkflowID: "",
},
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return("", nil)
},
expectError: true,
},
"empty workflow ID": {
request: &types.RespondActivityTaskFailedByIDRequest{
Domain: s.testDomain,
WorkflowID: "",
},
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return(s.testDomainID, nil)
},
expectError: true,
},
"empty activity ID": {
request: &types.RespondActivityTaskFailedByIDRequest{
Domain: s.testDomain,
WorkflowID: testWorkflowID,
ActivityID: "",
},
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return(s.testDomainID, nil)
},
expectError: true,
},
"exceeds id length limit": {
request: validRequest,
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return(s.testDomainID, nil)
wh.config.MaxIDLengthWarnLimit = dc.GetIntPropertyFn(1)
wh.config.IdentityMaxLength = dc.GetIntPropertyFilteredByDomain(1)
},
expectError: true,
},
"serialzation failure": {
request: validRequest,
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return(s.testDomainID, nil)
s.mockTokenSerializer.EXPECT().Serialize(gomock.Any()).Return(nil, errors.New("failed to deserialize token"))
},
expectError: true,
},
"return exceeds blob size limit": {
request: validRequest,
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return(s.testDomainID, nil)
s.mockTokenSerializer.EXPECT().Serialize(gomock.Any()).Return(make([]byte, 100), nil)
wh.config.BlobSizeLimitWarn = dc.GetIntPropertyFilteredByDomain(1)
wh.config.BlobSizeLimitError = dc.GetIntPropertyFilteredByDomain(1)
s.mockHistoryClient.EXPECT().RespondActivityTaskFailed(gomock.Any(), gomock.Any()).Return(nil)
},
expectError: false,
},
"history client returns error": {
request: validRequest,
mockFn: func() {
s.mockDomainCache.EXPECT().GetDomainID(s.testDomain).Return(s.testDomainID, nil)
s.mockTokenSerializer.EXPECT().Serialize(gomock.Any()).Return(make([]byte, 100), nil)
s.mockHistoryClient.EXPECT().RespondActivityTaskFailed(gomock.Any(), gomock.Any()).Return(errors.New("error"))
},
expectError: true,
},
}

for name, input := range testInput {
s.Run(name, func() {
input.mockFn()
err := wh.RespondActivityTaskFailedByID(context.Background(), input.request)
if input.expectError {
s.Error(err)
} else {
s.NoError(err)
}
wh.shuttingDown = int32(0)
wh.config.MaxIDLengthWarnLimit = dc.GetIntPropertyFn(1000)
wh.config.IdentityMaxLength = dc.GetIntPropertyFilteredByDomain(1000)

})
}
}

func updateRequest(
historyArchivalURI *string,
historyArchivalStatus *types.ArchivalStatus,
Expand Down
Loading