Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for reset_sticky_tasklist.go #6097

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add tests for reset_sticky_tasklist.go #6097

merged 1 commit into from
Jun 4, 2024

Conversation

natemort
Copy link
Member

@natemort natemort commented Jun 4, 2024

What changed?

  • Added unit tests

Why?

  • Increase test coverage

How did you test it?

  • Running the tests

Potential risks

  • None, this is test only.

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (cd8c132) to head (e79b892).
Report is 3 commits behind head on master.

Additional details and impacted files

see 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8c132...e79b892. Read the comment docs.

@natemort natemort merged commit 2c9795e into cadence-workflow:master Jun 4, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
@natemort @timl3136
Add tests for reset_sticky_tasklist.go (cadence-workflow#6097)
33b5e67
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
@natemort @timl3136
Add tests for reset_sticky_tasklist.go (cadence-workflow#6097)
01e0e44
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Jun 5, 2024
@natemort @dkrotx
Add tests for reset_sticky_tasklist.go (cadence-workflow#6097)
2df35c8
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@natemort @timl3136
Add tests for reset_sticky_tasklist.go (cadence-workflow#6097)
78d0d79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agautam478 agautam478 agautam478 approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natemort @agautam478