Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer version of github docker push action #6099

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

neil-xie
Copy link
Member

@neil-xie neil-xie commented Jun 4, 2024

What changed?
Multi-architecture builds and push action was introduced in v2, currently we are using v1 which is not working

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (2c9795e) to head (19d60db).
Report is 1 commits behind head on master.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9795e...19d60db. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 018fe532-b59d-4eba-9536-474b66d5e453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 107 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.04%) to 70.631%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/history/queue/transfer_queue_processor.go 2 56.49%
service/history/task/task.go 3 84.81%
common/persistence/nosql/nosql_task_store.go 3 85.52%
service/history/handler/handler.go 3 96.2%
service/frontend/api/handler.go 4 66.05%
common/task/fifo_task_scheduler.go 5 84.54%
service/history/execution/cache.go 6 74.61%
Totals Coverage Status
Change from base Build 018fe51b-2f78-4f20-9983-032a3377f62d: -0.04%
Covered Lines: 105206
Relevant Lines: 148952

💛 - Coveralls

@neil-xie neil-xie merged commit b38bd0c into cadence-workflow:master Jun 4, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Jun 5, 2024
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants