Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coveralls integration #6154

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Remove coveralls integration #6154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42c80d6
Remove coveralls integration
taylanisikdemir Jul 2, 2024
37e01c3
fix readme
taylanisikdemir Jul 2, 2024
df5660a
upgrade codecov action to latest version
taylanisikdemir Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .buildkite/pipeline-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,24 +285,6 @@ steps:

- wait

- label: ":golang: code-coverage"
retry:
automatic:
limit: 2
plugins:
- kubernetes:
<<: *kubernetes
podSpec:
<<: *podSpec
containers:
- <<: *commandContainer
command:
- |-
scripts/buildkite/gocov.sh
- docker-compose#v3.0.0:
run: coverage-report
config: docker/buildkite/docker-compose.yml

- label: ":docker: build and push master"
retry:
automatic:
Expand Down
18 changes: 0 additions & 18 deletions .buildkite/pipeline-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,24 +300,6 @@ steps:

- wait

- label: ":golang: code-coverage"
retry:
automatic:
limit: 2
plugins:
- kubernetes:
<<: *kubernetes
podSpec:
<<: *podSpec
containers:
- <<: *commandContainer
command:
- |-
scripts/buildkite/gocov.sh
- docker-compose#v3.0.0:
run: coverage-report
config: docker/buildkite/docker-compose.yml

- label: ":docker: build (no push)"
retry:
automatic:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
run: make cover_profile

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4.0.1 # https://github.com/codecov/codecov-action
uses: codecov/codecov-action@v4.5.0 # https://github.com/codecov/codecov-action
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrade should fix the coverage upload from fork originated PRs issue which broke coverage uploads recently

with:
file: .build/coverage/unit_cover.out
exclude: ./
Expand Down
8 changes: 1 addition & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,6 @@ $(BIN)/protoc-gen-gogofast: go.mod go.work | $(BIN)
$(BIN)/protoc-gen-yarpc-go: go.mod go.work | $(BIN)
$(call go_mod_build_tool,go.uber.org/yarpc/encoding/protobuf/protoc-gen-yarpc-go)

$(BIN)/goveralls: internal/tools/go.mod go.work
$(call go_build_tool,github.com/mattn/goveralls)

$(BUILD)/go_mod_check: go.mod internal/tools/go.mod go.work
$Q # generated == used is occasionally important for gomock / mock libs in general. this is not a definite problem if violated though.
$Q ./scripts/check-gomod-version.sh github.com/golang/mock/gomock $(if $(verbose),-v)
Expand Down Expand Up @@ -546,7 +543,7 @@ clean: ## Clean build products

# v----- not yet cleaned up -----v

.PHONY: git-submodules test bins build clean cover cover_ci help
.PHONY: git-submodules test bins build clean cover help

TOOLS_CMD_ROOT=./cmd/tools
INTEG_TEST_ROOT=./host
Expand Down Expand Up @@ -673,9 +670,6 @@ $(COVER_ROOT)/cover.out: $(UNIT_COVER_FILE) $(INTEG_COVER_FILE_CASS) $(INTEG_COV
cover: $(COVER_ROOT)/cover.out
go tool cover -html=$(COVER_ROOT)/cover.out;

cover_ci: $(COVER_ROOT)/cover.out $(BIN)/goveralls
$(BIN)/goveralls -coverprofile=$(COVER_ROOT)/cover.out -service=buildkite || echo Coveralls failed;

install-schema: cadence-cassandra-tool
$Q echo installing schema
./cadence-cassandra-tool create -k cadence --rf 1
Expand Down
51 changes: 25 additions & 26 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Cadence
[![Build Status](https://badge.buildkite.com/159887afd42000f11126f85237317d4090de97b26c287ebc40.svg?theme=github&branch=master)](https://buildkite.com/uberopensource/cadence-server)
[![Coverage Status](https://coveralls.io/repos/github/uber/cadence/badge.svg)](https://coveralls.io/github/uber/cadence)
[![Coverage](https://codecov.io/gh/uber/cadence/graph/badge.svg?token=7SD244ImNF)](https://codecov.io/gh/uber/cadence)
[![Slack Status](https://img.shields.io/badge/slack-join_chat-white.svg?logo=slack&style=social)](http://t.uber.com/cadence-slack)

[![Github release](https://img.shields.io/github/v/release/uber/cadence.svg)](https://GitHub.com/uber/cadence/releases)
Expand All @@ -10,42 +10,42 @@
[![GitHub forks](https://img.shields.io/github/forks/uber/cadence.svg?style=social&label=Fork&maxAge=2592000)](https://GitHub.com/uber/cadence/network/)


This repo contains the source code of the Cadence server and other tooling including CLI, schema tools, bench and canary.
This repo contains the source code of the Cadence server and other tooling including CLI, schema tools, bench and canary.

You can implement your workflows with one of our client libraries.
The [Go](https://github.com/uber-go/cadence-client) and [Java](https://github.com/uber-java/cadence-client) libraries are officially maintained by the Cadence team,
You can implement your workflows with one of our client libraries.
The [Go](https://github.com/uber-go/cadence-client) and [Java](https://github.com/uber-java/cadence-client) libraries are officially maintained by the Cadence team,
while the [Python](https://github.com/firdaus/cadence-python) and [Ruby](https://github.com/coinbase/cadence-ruby) client libraries are developed by the community.

You can also use [iWF](https://github.com/indeedeng/iwf) as a DSL framework on top of Cadence.
You can also use [iWF](https://github.com/indeedeng/iwf) as a DSL framework on top of Cadence.

See Maxim's talk at [Data@Scale Conference](https://atscaleconference.com/videos/cadence-microservice-architecture-beyond-requestreply) for an architectural overview of Cadence.

Visit [cadenceworkflow.io](https://cadenceworkflow.io) to learn more about Cadence. Join us in [Cadence Documentation](https://github.com/uber/cadence-docs) project. Feel free to raise an Issue or Pull Request there.

### Community
### Community
* [Github Discussion](https://github.com/uber/cadence/discussions)
* Best for Q&A, support/help, general discusion, and annoucement
* Best for Q&A, support/help, general discusion, and annoucement
* [StackOverflow](https://stackoverflow.com/questions/tagged/cadence-workflow)
* Best for Q&A and general discusion
* [Github Issues](https://github.com/uber/cadence/issues)
* Best for reporting bugs and feature requests
* [Slack](http://t.uber.com/cadence-slack)
* Best for contributing/development discussion
* Best for contributing/development discussion

## Getting Started

### Start the cadence-server

To run Cadence services locally, we highly recommend that you use [Cadence service docker](docker/README.md) to run the service.
You can also follow the [instructions](./CONTRIBUTING.md) to build and run it.
You can also follow the [instructions](./CONTRIBUTING.md) to build and run it.

Please visit our [documentation](https://cadenceworkflow.io/docs/operation-guide/) site for production/cluster setup.

### Run the Samples

Try out the sample recipes for [Go](https://github.com/uber-common/cadence-samples) or [Java](https://github.com/uber/cadence-java-samples) to get started.

### Use [Cadence CLI](https://cadenceworkflow.io/docs/cli/)
### Use [Cadence CLI](https://cadenceworkflow.io/docs/cli/)

Cadence CLI can be used to operate workflows, tasklist, domain and even the clusters.

Expand All @@ -55,11 +55,11 @@ You can use the following ways to install Cadence CLI:
* Use docker image for CLI: `docker run --rm ubercadence/cli:<releaseVersion>` or `docker run --rm ubercadence/cli:master ` . Be sure to update your image when you want to try new features: `docker pull ubercadence/cli:master `
* Build the CLI binary yourself, check out the repo and run `make cadence` to build all tools. See [CONTRIBUTING](CONTRIBUTING.md) for prerequisite of make command.
* Build the CLI image yourself, see [instructions](docker/README.md#diy-building-an-image-for-any-tag-or-branch)

Cadence CLI is a powerful tool. The commands are organized by **tabs**. E.g. `workflow`->`batch`->`start`, or `admin`->`workflow`->`describe`.

Please read the [documentation](https://cadenceworkflow.io/docs/cli/#documentation) and always try out `--help` on any tab to learn & explore.
Please read the [documentation](https://cadenceworkflow.io/docs/cli/#documentation) and always try out `--help` on any tab to learn & explore.

### Use Cadence Web

Try out [Cadence Web UI](https://github.com/uber/cadence-web) to view your workflows on Cadence.
Expand All @@ -75,32 +75,31 @@ If you'd like to propose a new feature, first join the [Slack channel](http://t.
## Other binaries in this repo

#### Bench/stress test workflow tools
See [bench documentation](./bench/README.md).
See [bench documentation](./bench/README.md).

#### Periodical feature health check workflow tools(aka Canary)
See [canary documentation](./canary/README.md).

#### Schema tools for SQL and Cassandra
The tools are for [manual setup or upgrading database schema](docs/persistence.md)
* If server runs with Cassandra, Use [Cadence Cassandra tool](tools/cassandra/README.md)
* If server runs with SQL database, Use [Cadence SQL tool](tools/sql/README.md)
The tools are for [manual setup or upgrading database schema](docs/persistence.md)

* If server runs with Cassandra, Use [Cadence Cassandra tool](tools/cassandra/README.md)
* If server runs with SQL database, Use [Cadence SQL tool](tools/sql/README.md)

The easiest way to get the schema tool is via homebrew.

`brew install cadence-workflow` also includes `cadence-sql-tool` and `cadence-cassandra-tool`.
`brew install cadence-workflow` also includes `cadence-sql-tool` and `cadence-cassandra-tool`.
* The schema files are located at `/usr/local/etc/cadence/schema/`.
* To upgrade, make sure you remove the old ElasticSearch schema first: `mv /usr/local/etc/cadence/schema/elasticsearch /usr/local/etc/cadence/schema/elasticsearch.old && brew upgrade cadence-workflow`. Otherwise ElasticSearch schemas may not be able to get updated.
* Follow the [instructions](https://github.com/uber/cadence/discussions/4457) if you need to install older versions of schema tools via homebrew.
However, easier way is to use new versions of schema tools with old versions of schemas.
All you need is to check out the older version of schemas from this repo. Run `git checkout v0.21.3` to get the v0.21.3 schemas in [the schema folder](/schema).
* Follow the [instructions](https://github.com/uber/cadence/discussions/4457) if you need to install older versions of schema tools via homebrew.
However, easier way is to use new versions of schema tools with old versions of schemas.
All you need is to check out the older version of schemas from this repo. Run `git checkout v0.21.3` to get the v0.21.3 schemas in [the schema folder](/schema).


## Stargazers over time
[![Stargazers over time](https://starchart.cc/uber/cadence.svg?variant=adaptive)](https://starchart.cc/uber/cadence)


## License

MIT License, please see [LICENSE](https://github.com/uber/cadence/blob/master/LICENSE) for details.

1 change: 0 additions & 1 deletion docker/buildkite/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@ services:
- BUILDKITE_BUILD_CREATOR_EMAIL
- BUILDKITE_BUILD_CREATOR_TEAMS
- BUILDKITE_PULL_REQUEST_REPO
- COVERALLS_TOKEN
volumes:
- ../../:/cadence

Expand Down
1 change: 0 additions & 1 deletion internal/tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ require (
github.com/gogo/protobuf v1.3.2
github.com/golang/mock v1.6.0
github.com/hexdigest/gowrap v1.2.5
github.com/mattn/goveralls v0.0.11
github.com/mgechev/revive v1.3.2
github.com/vektra/mockery/v2 v2.32.0
go.uber.org/thriftrw v1.29.2
Expand Down
2 changes: 0 additions & 2 deletions internal/tools/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,8 +850,6 @@ github.com/mattn/go-runewidth v0.0.9 h1:Lm995f3rfxdpd6TSmuVCHVb/QhupuXlYr8sCI/Qd
github.com/mattn/go-runewidth v0.0.9/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m2gUSrubnMI=
github.com/mattn/go-shellwords v1.0.10/go.mod h1:EZzvwXDESEeg03EKmM+RmDnNOPKG4lLtQsUlTZDWQ8Y=
github.com/mattn/go-sqlite3 v1.9.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsOqkbpncsNc=
github.com/mattn/goveralls v0.0.11 h1:eJXea6R6IFlL1QMKNMzDvvHv/hwGrnvyig4N+0+XiMM=
github.com/mattn/goveralls v0.0.11/go.mod h1:gU8SyhNswsJKchEV93xRQxX6X3Ei4PJdQk/6ZHvrvRk=
github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 h1:I0XW9+e1XWDxdcEniV4rQAIOPUGDq67JSCiRCgGCZLI=
github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369/go.mod h1:BSXmuO+STAnVfrANrmjBb36TMTDstsz7MSK+HVaYKv4=
Expand Down
2 changes: 0 additions & 2 deletions internal/tools/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import (
_ "github.com/golang/mock/mockgen"
// gowrap for generating decorators for interface
_ "github.com/hexdigest/gowrap"
// coverage reporting
_ "github.com/mattn/goveralls"
// replaces golint - configurable and much faster
_ "github.com/mgechev/revive"
// mockery for generating mocks
Expand Down
21 changes: 0 additions & 21 deletions scripts/buildkite/gocov.sh
View file
Open in desktop

This file was deleted.

Loading