Support for generating replication task on workflow execution updates #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Mar 21, 2018
| @@ -0,0 +1,114 @@ | |||
| // Copyright (c) 2017 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
since metadataTestBase.go is provided, this mock does not do much, is it?
There was a problem hiding this comment.
I'm using it in some unit test to assert IsGlobalDomain API.
|
looks like we have a dedicated replication task queue, does that means each host will start additional # of shard of go routine for acking & processing replication task? |
History engine changes to generate replication task when IsGlobalDomain is enabled. MutableStateBuilder is also updated to load replication state for the domain and have support for creating replication task on updates along with relevant updates to mutable state. Replication tasks are written to a separate queue for the shard. This requires persistence changes to write replication tasks on updates in the same transaction and new API for reading and completing the task. New AckLevel is needed for processing of replication tasks. This requires changes to shard crud on the persistence layer for reading and writing the new ack level for replication task processing. ClusterMetadata and MessagingClient are already exposed on the Service. So passing through Service to all layers in History service which needs access to both ClusterMetadata and MessagingClient.
wxing1292
reviewed
Mar 21, 2018
| // Types of replication tasks | ||
| const ( | ||
| ReplicationTaskTypeHistory = iota | ||
| ReplicationTaskTypeHeartbeat |
There was a problem hiding this comment.
is ReplicationTaskTypeHeartbeat in the next PR?
There was a problem hiding this comment.
Yes. This is for future purpose.
wxing1292
approved these changes
Mar 21, 2018
samarabbas
force-pushed
the
xdc-replicate-events
branch
from
8430eae
to
9902709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History engine changes to generate replication task when IsGlobalDomain
is enabled. MutableStateBuilder is also updated to load replication
state for the domain and have support for creating replication task on
updates along with relevant updates to mutable state.
Replication tasks are written to a separate queue for the shard. This
requires persistence changes to write replication tasks on updates in
the same transaction and new API for reading and completing the task.
New AckLevel is needed for processing of replication tasks. This
requires changes to shard crud on the persistence layer for reading and
writing the new ack level for replication task processing.
ClusterMetadata and MessagingClient are already exposed on the Service.
So passing through Service to all layers in History service which needs
access to both ClusterMetadata and MessagingClient.