Add additional options to matching simulation cases #6240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
approved these changes
Aug 20, 2024
| numpollers: 10 | ||
| tasklistwritepartitions: 4 | ||
| tasklistreadpartitions: 4 | ||
| numpollers: 8 |
There was a problem hiding this comment.
can you update host/testdata/matching_simulation_more_read_partitions.yaml as well? It should look similar to default.yaml except read partitions doubled.
abhishekj720
approved these changes
Aug 20, 2024
Add RecordDecisionTaskStartedTime to control the delay incurred by matching calling to history. Add TaskProcessTime to control the delay in-between polls. This is meant to represent time the client spends executing the task. Add TasksBurst to allow setting the burst value on the rate limiter, defaulting to a value of 1. Currently it uses the same value as the RPS which results in spikey behavior that causes sync matching to significantly underperform. Allow ForwarderMaxOutstandingPolls and ForwarderMaxOutstandingTasks to be zero. It's interesting to see a control without any forwarding. Additionally add a few test cases to showcase different behaviors of the current matching stack. This isn't a complete set yet but each of these brings some interesting behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RecordDecisionTaskStartedTime to control the delay incurred by matching calling to history.
Add TaskProcessTime to control the delay in-between polls. This is meant to represent time the client spends executing the task.
Add TasksBurst to allow setting the burst value on the rate limiter, defaulting to a value of 1. Currently it uses the same value as the RPS which results in spikey behavior that causes sync matching to significantly underperform.
Allow ForwarderMaxOutstandingPolls and ForwarderMaxOutstandingTasks to be zero. It's interesting to see a control without any forwarding.
Additionally add a few test cases to showcase different behaviors of the current matching stack. This isn't a complete set yet but each of these brings some interesting behavior.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes