-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor visibility migration code and add support for OpenSearch visibility migration #6284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-xie
requested review from
Shaddoll,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
September 12, 2024 20:26
neil-xie
force-pushed
the
CDNC-10433-1
branch
from
September 16, 2024 23:02
b9dece6
to
b45439a
Compare
shijiesheng
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also title would be misleading. It's actually introduce OpenSearch visibility rather than a pure refactoring
neil-xie
changed the title
Refactor visibility migration code
Refactor visibility migration code and add support for OpenSearch visibility migration
Sep 23, 2024
shijiesheng
reviewed
Sep 23, 2024
shijiesheng
approved these changes
Sep 24, 2024
davidporter-id-au
approved these changes
Sep 24, 2024
davidporter-id-au
approved these changes
Sep 24, 2024
shijiesheng
reviewed
Sep 25, 2024
shijiesheng
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
OpenSearch migration
How did you test it?
Unit test and manual test locally
Potential risks
Release notes
Documentation Changes