Fix port string to uint16 parsing #6291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Port strings are parsed to uint16 in ringpop library. Ports can be numbered from 0 to 65535 which is uint16 range.
Currently the parsing is done using
ParseInt
instead ofParseUint
which fails to parse ports greater than 32767.Why?
Avoid bugs for port numbers > 32767.
How did you test it?
Unit test.