Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test code for readability #6308

Merged

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Sep 26, 2024

What changed?

  • Refactor test code of pinot_query_validator for readability:
    • deleted all the double quotes backslash inside of strings, and quoted the entire string with ``.

Why?
for readability

How did you test it?
unti test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (71cf16a) to head (ddb6731).
Report is 5 commits behind head on master.

Additional details and impacted files

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71cf16a...ddb6731. Read the comment docs.

@bowenxia bowenxia enabled auto-merge (squash) September 27, 2024 00:45
@bowenxia bowenxia merged commit 6594452 into master Sep 27, 2024
19 checks passed
@bowenxia bowenxia deleted the xbowen_refactor_test_query_format_in_pinot_query_validator_00 branch September 27, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants