Add retry in some frontend API #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Mar 26, 2018
common/util.go
Outdated
| @@ -42,6 +42,10 @@ const ( | |||
| historyServiceOperationInitialInterval = 50 * time.Millisecond | |||
| historyServiceOperationMaxInterval = 10 * time.Second | |||
| historyServiceOperationExpirationInterval = 30 * time.Second | |||
|
|
|||
| frontendServiceOperationInitialInterval = 50 * time.Millisecond | |||
There was a problem hiding this comment.
personal preference: 50 is too low, 200 maybe a good idea
wxing1292
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oncall observed multiple pollForActivity/Decision error in short period which affects our SLA.
Error log shows as:
handler.go:385 PollForDecisionTask failed. TaskList: adjust_ledgerv2, Error: code:unknown message:received unknown error calling service: "cadence-matching", procedure: "MatchingService::PollForDecisionTask", err: dial tcp 10.189.33.24:31849: getsockopt: connection refused
We need to add retry logic in Frontend to mitigate such error affecting our SLA to client.