Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Emit usage logs after workflow diagnostics run #6316

Merged

Conversation

sankari165
Copy link
Contributor

@sankari165 sankari165 commented Sep 30, 2024

What changed?
Usage logs are emitted after workflow diagnostics run as an activity in the diagnostics starter workflow. Since this is a on demand usecase. kafka messaging client is only setup when needed

Why?
collect data for every workflow diagnostics run

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (7e2c9dd) to head (8a58009).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
service/worker/diagnostics/activities.go 46.15% 6 Missing and 1 partial ⚠️
service/worker/diagnostics/parent_workflow.go 85.29% 3 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/frontend/api/handler.go 65.99% <100.00%> (+0.01%) ⬆️
service/worker/diagnostics/module.go 100.00% <100.00%> (ø)
service/worker/diagnostics/parent_workflow.go 82.22% <85.29%> (+8.88%) ⬆️
service/worker/diagnostics/activities.go 78.78% <46.15%> (-21.22%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2c9dd...8a58009. Read the comment docs.

Copy link
Contributor

@ketsiambaku ketsiambaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sankari165 sankari165 merged commit ea3a90e into cadence-workflow:master Oct 3, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10485-data-emission branch October 3, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants