Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task reader timer #6324

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix task reader timer #6324

merged 1 commit into from
Oct 3, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 3, 2024

What changed?
Use Reset method instead of creating a new timer

Why?
This is the right way of using timer

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.53%. Comparing base (ea3a90e) to head (070b54c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
service/matching/tasklist/task_reader.go 33.33% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/matching/tasklist/task_reader.go 73.60% <33.33%> (+0.58%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3a90e...070b54c. Read the comment docs.

@Shaddoll Shaddoll merged commit 80f4739 into cadence-workflow:master Oct 3, 2024
19 of 20 checks passed
@Shaddoll Shaddoll deleted the timer branch October 3, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants