Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dependency injection for the main CLI #6331

Merged
merged 2 commits into from
Oct 7, 2024

Merge branch 'master' into cli-prep

f326478
Select commit
Loading
Failed to load commit list.
Merged

Switch to dependency injection for the main CLI #6331

Merge branch 'master' into cli-prep
f326478
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 0s

73.48% (target 85.00%)

View this Pull Request on Codecov

73.48% (target 85.00%)

Details

Codecov Report

Attention: Patch coverage is 14.79714% with 357 lines in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (084949b) to head (f326478).

Files with missing lines Patch % Lines
tools/cli/factory.go 0.00% 75 Missing ⚠️
tools/cli/workflow_commands.go 24.41% 51 Missing and 14 partials ⚠️
tools/cli/admin_commands.go 2.77% 34 Missing and 1 partial ⚠️
tools/cli/admin.go 13.04% 19 Missing and 1 partial ⚠️
tools/cli/domain_migration_command.go 0.00% 19 Missing ⚠️
tools/cli/admin_failover_commands.go 23.80% 13 Missing and 3 partials ⚠️
tools/cli/admin_dlq_commands.go 0.00% 15 Missing ⚠️
tools/cli/isolation-groups.go 0.00% 14 Missing ⚠️
tools/cli/admin_config_store_commands.go 0.00% 13 Missing ⚠️
tools/cli/workflow_batch_commands.go 0.00% 13 Missing ⚠️
... and 11 more
Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/admin_db_clean_command.go 0.00% <ø> (ø)
tools/cli/domain.go 64.70% <100.00%> (+4.70%) ⬆️
tools/cli/utils.go 55.98% <100.00%> (ø)
tools/cli/database.go 46.72% <0.00%> (ø)
tools/cli/cluster_commands.go 50.00% <33.33%> (-5.56%) ⬇️
tools/cli/admin_kafka_commands.go 0.00% <0.00%> (ø)
tools/cli/task_list_commands.go 42.18% <16.66%> (-2.82%) ⬇️
tools/cli/admin_task_list_commands.go 0.00% <0.00%> (ø)
tools/cli/app.go 95.09% <45.45%> (-3.64%) ⬇️
tools/cli/admin_async_queue_commands.go 0.00% <0.00%> (ø)
... and 14 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084949b...f326478. Read the comment docs.