Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Refactor to move all timeout related checks under one directory #6332

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

sankari165
Copy link
Member

What changed?
ll timeout related checks moved under one directory

Why?
to add more invariants to run workflow diagnostics

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link
Contributor

@arzonus arzonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

service/worker/diagnostics/invariants/timeouts/timeout.go Outdated Show resolved Hide resolved
service/worker/diagnostics/activities.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.63%. Comparing base (084949b) to head (a1f097f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ce/worker/diagnostics/invariant/timeout/timeout.go 82.60% 4 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/worker/diagnostics/activities.go 78.78% <100.00%> (ø)
...ker/diagnostics/invariant/timeout/timeout_utils.go 83.11% <ø> (ø)
service/worker/diagnostics/workflow.go 82.45% <100.00%> (ø)
...ce/worker/diagnostics/invariant/timeout/timeout.go 86.88% <82.60%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084949b...a1f097f. Read the comment docs.

@sankari165 sankari165 merged commit a155019 into cadence-workflow:master Oct 7, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10786 branch October 7, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants