Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] rootcause simple worker service caused activity and workflow failures #6351

Merged

Conversation

sankari165
Copy link
Member

@sankari165 sankari165 commented Oct 10, 2024

What changed?
provide rootcause for simple worker service side activity and workflow failures

Why?
custom errors and panic errors are definitely caused by worker service. Follow up PRs will add more rootcause options for other failures

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@sankari165 sankari165 changed the title [Wf-Diagnostics] rootcause simple service side activity and workflow failures [Wf-Diagnostics] rootcause simple worker service caused activity and workflow failures Oct 10, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.74%. Comparing base (5915fed) to head (9b3cb5c).
Report is 3 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
...ce/worker/diagnostics/invariant/failure/failure.go 97.91% <100.00%> (+5.23%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5915fed...9b3cb5c. Read the comment docs.

@sankari165 sankari165 merged commit 77c61f2 into cadence-workflow:master Oct 11, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10787-simple-failure branch October 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants