Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Point to activity task for activity failures #6355

Merged

Conversation

sankari165
Copy link
Contributor

What changed?
Failure metadata has details on activity task scheduled and started event attributes

Why?
To provide more info on the activity that failed

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (77c61f2) to head (de98273).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ce/worker/diagnostics/invariant/failure/failure.go 88.23% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ce/worker/diagnostics/invariant/failure/failure.go 95.31% <88.23%> (-2.61%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c61f2...de98273. Read the comment docs.

@sankari165 sankari165 merged commit a32159c into cadence-workflow:master Oct 14, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10787-activity-failure branch October 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants