[CLI] fix incorrect propagation of span context in start workflow #6363
Conversation
shijiesheng
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| @@ -526,12 +526,15 @@ func processHeader(c *cli.Context) (map[string][]byte, error) { | |||
| headers := mapFromKeysValues(headerKeys, headerValues) | |||
| // append context headers if exist | |||
| if span := opentracing.SpanFromContext(c.Context); span != nil && span.Context() != nil { | |||
| span.Context().ForeachBaggageItem(func(k, v string) bool { | |||
There was a problem hiding this comment.
how did you find out this doesn't work? Does the unit test change cover it?
There was a problem hiding this comment.
When I test with internal tracer, I realize the headers key doesn't match. Now the unit test coverage covered it. (prefix mockpfx-baggage-)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
What changed?
Why?
Simply passing baggage key/values won't work.
How did you test it?
Unit test
Potential risks
Release notes
Documentation Changes