Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Include failure issues identification and rootcause in diagnostics #6370

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

sankari165
Copy link
Member

What changed?
Include failure issues identification and rootcause in diagnostics workflow

Why?
these invariants will become part of diagnostics

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 75.94937% with 19 lines in your changes missing coverage. Please review.

Project coverage is 74.87%. Comparing base (084464e) to head (58d48b3).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
service/worker/diagnostics/workflow.go 77.50% 5 Missing and 4 partials ⚠️
service/worker/diagnostics/activities.go 73.33% 4 Missing and 4 partials ⚠️
...ce/worker/diagnostics/invariant/timeout/timeout.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ce/worker/diagnostics/invariant/failure/failure.go 95.31% <100.00%> (ø)
service/worker/diagnostics/module.go 100.00% <100.00%> (ø)
...ce/worker/diagnostics/invariant/timeout/timeout.go 86.99% <60.00%> (+0.10%) ⬆️
service/worker/diagnostics/activities.go 74.57% <73.33%> (-4.22%) ⬇️
service/worker/diagnostics/workflow.go 81.81% <77.50%> (-0.64%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084464e...58d48b3. Read the comment docs.

Copy link
Contributor

@ketsiambaku ketsiambaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sankari165 sankari165 merged commit 1ba0d71 into cadence-workflow:master Oct 17, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10788-wf branch October 17, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants