Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matching handlers to return TaskListPartitionConfig in responses #6376

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 18, 2024

What changed?

  • Update matching handlers to return TaskListPartitionConfig in responses
  • Update non-root partition to load partition config from database

Why?
To migrate tasklist partition config from dynamic config to database

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll force-pushed the resp branch 6 times, most recently from 32b9f81 to 6980451 Compare October 19, 2024 16:15
@cadence-workflow cadence-workflow deleted a comment from codecov bot Oct 19, 2024
@cadence-workflow cadence-workflow deleted a comment from codecov bot Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 84.07643% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.86%. Comparing base (877ccae) to head (3952659).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
service/matching/handler/engine.go 70.17% 15 Missing and 2 partials ⚠️
service/matching/tasklist/task_list_manager.go 91.07% 4 Missing and 1 partial ⚠️
service/matching/tasklist/db.go 90.32% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
common/persistence/data_manager_interfaces.go 94.91% <100.00%> (+0.20%) ⬆️
service/matching/handler/handler.go 100.00% <100.00%> (ø)
service/matching/tasklist/db.go 83.87% <90.32%> (+13.62%) ⬆️
service/matching/tasklist/task_list_manager.go 72.08% <91.07%> (+4.22%) ⬆️
service/matching/handler/engine.go 82.61% <70.17%> (-0.07%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b75b7d...3952659. Read the comment docs.

@Shaddoll Shaddoll changed the title wip: Update matching handlers to return TaskListPartitionConfig in responses Update matching handlers to return TaskListPartitionConfig in responses Oct 20, 2024
@Shaddoll Shaddoll marked this pull request as ready for review October 20, 2024 01:26
@Shaddoll Shaddoll merged commit 719eb07 into cadence-workflow:master Oct 21, 2024
20 checks passed
@Shaddoll Shaddoll deleted the resp branch October 21, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants