Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for nosql create tasks method #6379

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 21, 2024

What changed?
Add unit test for nosql create tasks method

Why?
Improve test coverage (43 lines)

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link
Member

@bowenxia bowenxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (719eb07) to head (a205fb2).
Report is 5 commits behind head on master.

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719eb07...a205fb2. Read the comment docs.

@Shaddoll Shaddoll merged commit 3232f71 into cadence-workflow:master Oct 21, 2024
20 checks passed
@Shaddoll Shaddoll deleted the test2 branch October 21, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants