Adding a test for admin_commands #6414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
reviewed
Oct 25, 2024
dkrotx
force-pushed
the
testcov-admin-commands
branch
from
e0a195f to
12729cb
Compare
For now it is a test for a single function: ResetQueue Inroducing clitest package as a helper to write cli tests. Previously we were mistakenly overriding flags in flag.FlagSet which does not align with `context.IsSet()` - it thinks user did not provide an argument.
To follow a new, shorter approach with newCLITestData/clitest.
To follow a new, shorter approach with newCLITestData/clitest.
dkrotx
force-pushed
the
testcov-admin-commands
branch
from
12729cb to
4a703d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
For now it is a test for a single function: ResetQueue
Inroducing clitest package as a helper to write cli tests.
Previously we were mistakenly overriding flags in flag.FlagSet which
does not align with
context.IsSet()- it thinks user did not providean argument.
Why?
Improving test-coverage
How did you test it?
Unit-test itself
Potential risks
Release notes
Documentation Changes