Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for config store manager #6419

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 25, 2024

What changed?
Add unit tests for config store manager

Why?
Improve coverage (34 lines)

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (2fd0fbc) to head (3557de2).
Report is 3 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
common/persistence/config_store_manager.go 100.00% <ø> (ø)
common/persistence/data_store_interfaces.go 100.00% <ø> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd0fbc...3557de2. Read the comment docs.

@Shaddoll Shaddoll merged commit b8f6da5 into cadence-workflow:master Oct 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants