Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple bugs in frontend #642

Merged
merged 6 commits into from
Mar 30, 2018
Merged

Fix multiple bugs in frontend #642

merged 6 commits into from
Mar 30, 2018

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Mar 30, 2018 •
edited
Loading

  • check domain and other fields not be nil or empty
  • check nil for all requests
  • fix queryWorkflow empty runID check
  • use "get methods" instead of dereference

@vancexu vancexu mentioned this pull request Mar 30, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 63.264% when pulling f9b2e24 on front into 07555d8 on master.

@vancexu vancexu merged commit 3e3e2fc into master Mar 30, 2018
@vancexu vancexu deleted the front branch March 30, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

@samarabbas samarabbas Awaiting requested review from samarabbas

@yiminc-zz yiminc-zz Awaiting requested review from yiminc-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vancexu @coveralls @wxing1292