Move away from zero-RPS == unlimited-RPS, as it isn't always correct #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Global" RPS limits have a surprising fallback that keeps confusing us: if the configured RPS is zero, it ignores the limit entirely and only uses the per-instance RPS (e.g. `FrontendMaxDomainVisibilityRPSPerInstance`). But since these are generally used in a tiered setup with those same limits, this doesn't really do anything except repeatedly mislead us that "0" means "unlimited" because the per-instance-RPS values are generally very high. So this moves one away and adds some documentation about it. There may be others, but they aren't adjusted anywhere near as much as these three.
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Shaddoll
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Global" RPS limits have a surprising fallback that keeps confusing us:
if the configured RPS is zero, it ignores the limit entirely and only
uses the per-instance RPS (e.g.
FrontendMaxDomainVisibilityRPSPerInstance).But since these are generally used in a tiered setup with those same limits,
this doesn't really do anything except repeatedly mislead us that "0" means
"unlimited" because the per-instance-RPS values are generally very high.
So this moves one away and adds some documentation about it. There may be
others, but they aren't adjusted anywhere near as much as these three.