Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for admin_kafka_commands #6479

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Tests for admin_kafka_commands #6479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1aadff5
Tests for admin_kafka_commands
tubignat Nov 5, 2024
ef31091
After review
tubignat Nov 5, 2024
3f9ecb4
Merge branch 'uber:master' into master
tubignat Nov 5, 2024
f9fcccf
after rebase
tubignat Nov 5, 2024
6ef8eb0
Fixed formatting
tubignat Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tools/cli/admin_db_scan_command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,7 @@ func expectWorkFlow(td *cliTestData, workflowID string) {
func TestAdminDBScanUnsupportedWorkflow(t *testing.T) {
td := newCLITestData(t)

outPutFile, cleanup := createTempFileWithContent(t, "")
defer cleanup()
outPutFile := createTempFileWithContent(t, "")

expectShard(td, 123)
expectShard(td, 124)
Expand Down
3 changes: 1 addition & 2 deletions tools/cli/admin_kafka_commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func getOutputFile(outputFile string) (*os.File, error) {
return f, nil
}

func startReader(file *os.File, readerCh chan<- []byte) error {
func startReader(file io.Reader, readerCh chan<- []byte) error {
defer close(readerCh)
reader := bufio.NewReader(file)

Expand Down Expand Up @@ -533,7 +533,6 @@ func decodeReplicationTask(
task *types.ReplicationTask,
serializer persistence.PayloadSerializer,
) ([]byte, error) {

switch task.GetTaskType() {
case types.ReplicationTaskTypeHistoryV2:
historyV2 := task.GetHistoryTaskV2Attributes()
Expand Down
Loading
Loading