Add IDL for shard distributor lookups #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
force-pushed
the
shardManagerServiceLookupIdls
branch
from
2151230 to
eb60826
Compare
3vilhamster
approved these changes
Nov 21, 2024
3vilhamster
reviewed
Nov 21, 2024
3vilhamster
reviewed
Nov 21, 2024
| } | ||
|
|
||
| message GetShardOwnerResponse { | ||
| string owner = 1; |
There was a problem hiding this comment.
What is owner here? host:port or just host or some other identity? Please make it clear in the comments in proto file so API is self descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added IDLs for looking up the owner of a shard in shard distributor
Why?
To enable looking up the owner of a shard in shard distributor
How did you test it?
Potential risks
Release notes
Documentation Changes