Enable graceful shutdown of replication task fetcher by default #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
davidporter-id-au
approved these changes
Dec 19, 2024
taylanisikdemir
deleted the
taylan/replication_task_fetcher_shutdown_fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replication task fetcher is not respecting shut down signal because it uses background context. This causes integration test flakiness (example). I have fixed the shutdown logic of this component last year in #5544 but it was behind a feature flag. Removing that flag and enabling the correct behavior by default.
When
Stop()is called it will cancel internal context and rpc will terminate early. There's no side effect on replication ack levels.Why?
Better shutdown handling and reduce test flakyness.
How did you test it?
unit and integration tests