reduce number of calls to update shard #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
approved these changes
May 15, 2018
| @@ -107,30 +110,31 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int) *Config { | |||
| TimerTaskMaxRetryCount: 5, | |||
| TimerProcessorGetFailureRetryCount: 5, | |||
| TimerProcessorCompleteTimerFailureRetryCount: 10, | |||
| TimerProcessorUpdateAckInterval: 10 * time.Second, | |||
| TimerProcessorForceUpdateInterval: 10 * time.Minute, | |||
| TimerProcessorUpdateShardTaskCount: 100, | |||
There was a problem hiding this comment.
Let's file a task to make these dynamic config knobs.
| TransferProcessorUpdateShardTaskCount: 100, | ||
| TransferProcessorMaxPollInterval: 60 * time.Second, | ||
| TransferProcessorUpdateAckInterval: 1 * time.Minute, | ||
| TransferProcessorCompleteTransferInterval: 1 * time.Second, |
There was a problem hiding this comment.
1 second for complete sounds pretty low, considering we have 16K shards. I think it should also be notification based when there is something to cleanup.
Let's file a task to review all service configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #634