CrossDC bugfixes to replication task generation and conflict resolver #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replication information captured for replication task has the wrong last event id, as it is captured before CloseSession on mutable state. Update stale replication task detection to use LastWriteEventID instead of Current version. Otherwise this results in throwing away tasks when they could potentially be applied. Fix broken conflict resolution logic to set mutable state fields like next event id, lastFirstEventID, etc which were not set as a result of applying history events and need to be set explicitly.
|
fixes #792 |
wxing1292
reviewed
May 30, 2018
| if batchSize > eventsToApply { | ||
| history.Events = history.Events[0:eventsToApply] | ||
| } | ||
|
|
There was a problem hiding this comment.
missing a
eventsToApply -= int64(len(history.Events))
here
wxing1292
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replication information captured for replication task has the wrong
last event id, as it is captured before CloseSession on mutable state.
Update stale replication task detection to use LastWriteEventID instead
of Current version. Otherwise this results in throwing away tasks when
they could potentially be applied.
Fix broken conflict resolution logic to set mutable state fields like
next event id, lastFirstEventID, etc which were not set as a result of
applying history events and need to be set explicitly.
fix #792 #796