Fix error during Ringpop refresh #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #737 which is bothering us in Travis long time since TestIntegrationCrossDCSuite was added.
The root cause is:
During stop process of cadence server, it could stop ringpop at the time there are other go routines call refresh (which need ringpop be alive). Because TestIntegrationCrossDCSuite start/stop cadence server for each test case, it exposes this issue more frequently than previously.
This fix by switching from log.Fatal to log.Warn is safe.
(Another fix would be change the stop process to wait before stop ringpop, but it will be flaky and slow down our tests, so not used.)