bugfix: reset mutable state #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
reviewed
Jun 2, 2018
| @@ -106,6 +106,7 @@ func (r *conflictResolver) reset(replayEventID int64, startTime time.Time) (*mut | |||
| resetMutableStateBuilder.executionInfo.StartTimestamp = startTime | |||
| // the last updated time is not important here, since this should be updated with event time afterwards | |||
| resetMutableStateBuilder.executionInfo.LastUpdatedTimestamp = startTime | |||
| resetMutableStateBuilder.updateReplicationStateLastEventID(sourceCluster, replayEventID) | |||
There was a problem hiding this comment.
I think just setting the lastWriteEventID won't be enough. We also need to set the lastWriteVersion correctly too.
There was a problem hiding this comment.
those are updated in #806
samarabbas
reviewed
Jun 2, 2018
| @@ -142,7 +142,7 @@ func (r *historyReplicator) ApplyEvents(request *h.ReplicateEventsRequest) (retE | |||
| request.GetSourceCluster(), request.GetVersion(), request.GetFirstEventId(), request.GetNextEventId()) | |||
|
|
|||
| resolver := newConflictResolver(r.shard, context, r.historyMgr, r.logger) | |||
| msBuilder, err = resolver.reset(ri.GetLastEventId(), msBuilder.executionInfo.StartTimestamp) | |||
| msBuilder, err = resolver.reset(request.GetSourceCluster(), ri.GetLastEventId(), msBuilder.executionInfo.StartTimestamp) | |||
There was a problem hiding this comment.
I think it is incorrect to pass in the source cluster on the replication task. It needs to be inferred from the lastWriteVersion.
There was a problem hiding this comment.
those are updated in #806
|
close in favor of #806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.