Support for retrying messages within replicator processor #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Jun 8, 2018
| case *shared.RetryTaskError: | ||
| p.metricsClient.IncCounter(scope, metrics.CadenceErrRetryTaskCounter) | ||
| case *yarpcerrors.Status: | ||
| if err.Code() == yarpcerrors.CodeDeadlineExceeded { |
There was a problem hiding this comment.
ok that is actually correct
wxing1292
approved these changes
Jun 8, 2018
Kafka consumer for replication of events now only relies on actual topic it is consuming from and DLQ for messages which cannot be processed due to bugs in the replication stack. We no longer uses retry queue for the configured consumer. Replication message processing will now infinitely sit in the loop of transient errors in processing the message. In the event where processing logic returns RetryTaskError, it will retry that error few times before moving the message to DLQ. Also added a bunch of new metric to help with debugging replication related issues.
samarabbas
force-pushed
the
retry-queue-support-for-replicator
branch
from
2fa2455
to
cf9fdc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka consumer for replication of events now only relies on actual topic
it is consuming from and DLQ for messages which cannot be processed due
to bugs in the replication stack. We no longer uses retry queue for the
configured consumer.
Replication message processing will now infinitely sit in the loop of
transient errors in processing the message. In the event where
processing logic returns RetryTaskError, it will retry that error few
times before moving the message to DLQ.
Also added a bunch of new metric to help with debugging replication
related issues.