Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle DomainNotActive error in timer / transfer queue #878

Merged
merged 5 commits into from
Jun 23, 2018
Merged

handle DomainNotActive error in timer / transfer queue #878

merged 5 commits into from
Jun 23, 2018

Conversation

wxing1292
Copy link
Contributor

solve #843

samarabbas
samarabbas reviewed Jun 22, 2018
View reviewed changes
service/history/queueProcessor.go Outdated
// just keep try for cache.DomainCacheRefreshInterval
// and giveup
switch err.(type) {
case *workflow.DomainNotActiveError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may cause retries in tight loop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right

@wxing1292 wxing1292 merged commit 5530848 into master Jun 23, 2018
@wxing1292 wxing1292 deleted the queue-domain-not-active branch June 23, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarabbas samarabbas samarabbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxing1292 @samarabbas