Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedupe logic for heartbeat timer creation #962

Conversation

samarabbas
Copy link
Contributor

After moving timer deletion to a background job, it is highly likely to
process timers multiple times. Heartbeat timer processing is made
idempotent by keeping track of the timeout visibility within
mutable state whenever a new timer is created. And we only clear
the timer flag if the last timeout visibility is less than or equal to
visibility timestamp of the timer task.

@wxing1292 wxing1292 merged commit cbbff60 into cadence-workflow:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants