Adding more metrics, fix some bugs #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding more metrics * Fix bugs in retry policy
samarabbas
reviewed
Jul 16, 2018
| logging.TagFirstEventID: request.GetFirstEventId(), | ||
| logging.TagNextEventID: request.GetNextEventId(), | ||
| }) | ||
|
|
||
| r.metricsClient.RecordTimer( |
There was a problem hiding this comment.
It seems strange to report replication events size as a timer which is generally used for computing latencies. Is the intention here to compute various percentiles for this counter?
There was a problem hiding this comment.
yes, i would like to get the distribution of the number of events per replication task, this can be useful for debugging or explaining the potential high latency issue
samarabbas
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #941