Bugfix replication protocol #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2018 16:01
…enerated, thus not replication info will be added. Under this condition, the a double failover will increase the failover version, with no replication info, and the request is still valid
samarabbas
reviewed
Jul 19, 2018
| @@ -199,7 +199,10 @@ func (p *replicationTaskProcessor) processWithRetry(msg kafka.Message, workerID | |||
| forceBuffer := false | |||
| remainingRetryCount := p.config.ReplicationTaskMaxRetry | |||
|
|
|||
| attempt := 0 | |||
There was a problem hiding this comment.
We already have an attempt variable as part of for loop. Can we just have a one instead of 2?
There was a problem hiding this comment.
Probably you also want to include attempt on warn logs for every 100 failures.
samarabbas
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: when workflow is idle during the failover, no event will be generated, thus not replication info will be added; if a double failover is done for this workflow, the source cluster is not changed at all, so no replication info is needed.
Add more metrics on worker
Related to #944