Merge pull request #79 from cadifyai/67-parameter-values-of-type-int-…

…should-also-work-with-type-float

Allow implicit conversion from int to float

tests/functions.py

@@ -12,6 +12,16 @@ def function_no_params():
     return None
 
 
+@EnableTool
+def function_float(a: float):
+    """
+    This is a test function.
+
+    :param a: This is a parameter
+    """
+    return a
+
+
 @EnableTool
 def function(a: int, b: str, c: bool = False, d: list[int] = [1, 2, 3]):
     """

tests/test_load.py

@@ -139,3 +139,12 @@ def test_load_invalid_argument_values(function, arguments):
     f, args = LoadToolEnabled(functions, f_obj, validate=False)
     assert f == function
     assert args == arguments
+
+################################################
+#  Test implicit conversion from int to float  #
+################################################
+
+def test_function_float():
+    f, args = LoadToolEnabled(functions, get_function_dict(functions.function_float, {"a": 1}))
+    assert f == functions.function_float
+    assert args == {"a": 1}

tests/test_schema.py

@@ -26,8 +26,9 @@
 def test_FindToolEnabled():
     tools = FindToolEnabled(functions)
     # Check that the function is found
-    assert len(tools) == 7
+    assert len(tools) == 8
     assert functions.function in tools
+    assert functions.function_float in tools
     assert functions.function_tags in tools
     assert functions.function_no_params in tools
     assert functions.function_no_params in tools
@@ -43,8 +44,9 @@ def test_FindToolEnabled():
 def test_FindToolEnabledSchemas():
     tool_schemas = FindToolEnabledSchemas(functions)
     # Check that the function is found
-    assert len(tool_schemas) == 7
+    assert len(tool_schemas) == 8
     assert functions.function.to_json() in tool_schemas
+    assert functions.function_float.to_json() in tool_schemas
     assert functions.function_tags.to_json() in tool_schemas
     assert functions.function_no_params.to_json() in tool_schemas
     assert functions.function_literal.to_json() in tool_schemas
@@ -57,8 +59,9 @@ def test_FindToolEnabledSchemas():
 def test_FindToolEnabledSchemas_with_type(schema_type):
     # Check that the function is found
     tool_schemas = FindToolEnabledSchemas(functions, schema_type=schema_type)
-    assert len(tool_schemas) == 7
+    assert len(tool_schemas) == 8
     assert functions.function.to_json(schema_type) in tool_schemas
+    assert functions.function_float.to_json(schema_type) in tool_schemas
     assert functions.function_tags.to_json(schema_type) in tool_schemas
     assert functions.function_no_params.to_json(schema_type) in tool_schemas
     assert functions.function_literal.to_json(schema_type) in tool_schemas

tool2schema/type_schema.py

@@ -139,6 +139,9 @@ def matches(p_type) -> bool:
         return True
 
     def validate(self, value) -> bool:
+        # Allow implicit conversion from int to float
+        if self.type is float and type(value) is int:
+            return True
         return self.type == type(value)
 
     def _get_type(self) -> dict: