Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert from schema to function #59

Merged
merged 17 commits into from
Mar 25, 2024
Merged

Convert from schema to function #59

merged 17 commits into from
Mar 25, 2024

Conversation

lorenzocelli
Copy link
Contributor

No description provided.

@lorenzocelli lorenzocelli linked an issue Mar 15, 2024 that may be closed by this pull request
Convert from schema to function #48
Closed
@lorenzocelli lorenzocelli self-assigned this Mar 15, 2024
@lorenzocelli
Copy link
Contributor Author

@siliconlad do we want the validation to fail if the parameter description is missing from the schema? At the moment it fails but I feel like it is more of a side effect than something we would like to happen. The same can be said for the default value I guess.

Also, do we want to support tune schemas?

@siliconlad
Copy link
Member

Ah sorry. Slight confusion here I think.

I mean converting what we get from OpenAI. Such that we can convert it into a function that can be executed.

Screenshot_20240315-162821.png

@lorenzocelli
Copy link
Contributor Author

Ah ok I understand now, will do!

@lorenzocelli
Copy link
Contributor Author

Should be done with ef26dde

@lorenzocelli lorenzocelli marked this pull request as ready for review March 16, 2024 11:44
siliconlad
siliconlad requested changes Mar 17, 2024
View reviewed changes
Copy link
Member

@siliconlad siliconlad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

tool2schema/schema.py Outdated Show resolved Hide resolved
tool2schema/__init__.py Outdated Show resolved Hide resolved
tool2schema/schema.py Outdated Show resolved Hide resolved
tool2schema/schema.py Outdated Show resolved Hide resolved
tool2schema/type_schema.py Outdated Show resolved Hide resolved
tool2schema/schema.py Outdated Show resolved Hide resolved
tests/functions.py Show resolved Hide resolved
siliconlad
siliconlad requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@siliconlad siliconlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more small comments.

tool2schema/schema.py Outdated Show resolved Hide resolved
tool2schema/schema.py Outdated Show resolved Hide resolved
tool2schema/schema.py Outdated Show resolved Hide resolved
tool2schema/schema.py Outdated Show resolved Hide resolved
tests/test_schema.py Show resolved Hide resolved
tool2schema/schema.py Outdated Show resolved Hide resolved
siliconlad
siliconlad approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@siliconlad siliconlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siliconlad siliconlad self-requested a review March 25, 2024 16:20
@siliconlad siliconlad merged commit f810159 into main Mar 25, 2024
5 checks passed
@siliconlad siliconlad deleted the feature/schema-to-function branch March 25, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siliconlad siliconlad siliconlad approved these changes

Assignees

@lorenzocelli lorenzocelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert from schema to function
2 participants
@lorenzocelli @siliconlad