Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rtl support and Persian translation to mamte #185 #213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

khajavi
Copy link
Contributor

@khajavi khajavi commented Dec 31, 2015

refer to this issue I've put all my rtl css properties in custom.css but I don't know how to specialize this file just for Persian locale.
Any help?

@xdarklight
Copy link
Contributor

I think e8a4056 should add a file called "rtl.css" (instead of naming it custom.css).
And the file should only be included whenever a RTL language is active - always including it means that you are switching English and German users also to RTL, whereas they are used to LTR :)

@csokol
Copy link
Contributor

csokol commented Feb 3, 2016

This is awesome contribution, great work, @khajavi!

I agree with @xdarklight, "custom.css" is supposed to be used by mamute users (not by developers) to make small ui changes. I think you should put your css in another file and include it to the html only if an rtf language is being used (maybe adding a feature toggle?)

Can you do it, @khajavi? This is an awesome contribution and it would be great to ship it to master :-)

(notice that you still need to fix the review I left for you at #212)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants