Skip to content

Commit

Permalink
Assembling weld artifacts
Browse files Browse the repository at this point in the history
  • Loading branch information
@garcia-jj
garcia-jj committed Sep 2, 2014
1 parent 8e4b8f4 commit 6e87866
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions vraptor-core/assembly.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,23 @@
<include>javax.ejb:javax.ejb-api</include>
</includes>
</dependencySet>

<dependencySet>
<unpack>false</unpack>
<outputDirectory>lib/weld</outputDirectory>
<scope>test</scope>
<includes>
<include>org.jboss.weld.se:weld-se-core</include>
<include>org.jboss.weld:weld-spi</include>
<include>org.jboss.weld:weld-api</include>
<include>org.jboss.weld:weld-core-impl</include>
<include>org.jboss.classfilewriter:jboss-classfilewriter</include>
<include>org.jboss.spec.javax.el:jboss-el-api_3.0_spec</include>

This comment has been minimized.

Sign in to view

Copy link
@csokol

csokol Sep 2, 2014

Contributor

I think this artifact conlficts with javax.el:javax.el-api. If I'm not wrong this is a full copy of the classes from el-api.

This comment has been minimized.

Sign in to view

Copy link
@garcia-jj

garcia-jj Sep 3, 2014

Author Member

Sorry, I didn't understand first time I read. Now I see your point, and you right. I removed the javax.el. What you think?

This comment has been minimized.

Sign in to view

Copy link
@csokol

csokol Sep 3, 2014

Contributor

I think it solves the problem but isn't better to remove jboss-el-api_3.0_spec? Since this is copy and not the original...

This comment has been minimized.

Sign in to view

Copy link
@garcia-jj

garcia-jj Sep 4, 2014

Author Member

I don't think so, because Weld depends on jboss-el-api_3.0_spec, and not on javax.el:javax.el-api. May using non default artifact we can receive a ClassNotFoundException.

I don't have any non managed here to test. Have you interest to test in real app?

This comment has been minimized.

Sign in to view

Copy link
@csokol

csokol Sep 5, 2014

Contributor

Sorry, @garcia-jj, I've tested only now. I think that a weld dependency is still missing, we should add weld-servlet-core, right?

By the way, is weld-se-core really necessary?

This comment has been minimized.

Sign in to view

Copy link
@csokol

csokol Sep 5, 2014

Contributor

Shouldn't hibernate-validator-cdi be included in the validation/ folder? Anyway, those jars are also mandatory, right? I think we should move them to mandatory folder.

This comment has been minimized.

Sign in to view

Copy link
@csokol

csokol Sep 5, 2014

Contributor

it seems that jstl is also required since we are using javax.servlet.jsp.jstl.core.Config in our code... :-\

sorry for the flood... I'm solving problem by problem and reporting here

This comment has been minimized.

Sign in to view

Copy link
@garcia-jj

garcia-jj Sep 6, 2014

Author Member

Bean Validation is mandatory only if you run in a Servlet Container. Application servers don't. Because of this is delivered in a sub-folder. In mandatory folder we have only jars that don't exists in both Application Servers and Servlet Containers. In this case I think that we can leave as is, because in a Servlet Containers jars in Java EE are also required too. So... may better to keep in sub-folders.

This comment has been minimized.

Sign in to view

Copy link
@garcia-jj

garcia-jj Sep 6, 2014

Author Member

Yes, @csokol. org.jboss.weld.servlet:weld-servlet-core added. I've compared with musicjungle, and its necessary. All commits you suggested are done. Thank you. Tell me if you have more suggestions.
<include>org.jboss.spec.javax.interceptor:jboss-interceptors-api_1.2_spec</include>
<include>org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec</include>
<include>javax.el:javax.el-api</include>
</includes>
</dependencySet>

<dependencySet>
<unpack>false</unpack>
Expand Down

0 comments on commit 6e87866

Please sign in to comment.