Using EL Expression tests for messages

[garcia-jj]

May be useful? I think that we can improve our tests checking if expression language can catch properly some objects we export to view.

Since javax.el artifact is marked as provided, I think that won't generated any dependency problem.

[rponte]

Nice!

On Sunday, August 31, 2014, Otávio Garcia notifications@github.com wrote:

May be useful? I think that we can improve our tests checking if
expression language can catch properly some objects we export to view.

Since javax.el artifact is marked as provided, I think that won't

generated any dependency problem.

You can merge this Pull Request by running

git pull https://github.com/caelum/vraptor4 ot-messagestestwith-el

Or view, comment on, or merge it at:

#770
Commit Summary

• Using EL Expression tests for messages

File Changes

• M vraptor-core/pom.xml
  https://github.com/caelum/vraptor4/pull/770/files#diff-0 (15)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/validator/MessagesTest.java
  https://github.com/caelum/vraptor4/pull/770/files#diff-1 (26)

Patch Links:

• https://github.com/caelum/vraptor4/pull/770.patch
• https://github.com/caelum/vraptor4/pull/770.diff

—
Reply to this email directly or view it on GitHub
#770.

Rafael Ponte
TriadWorks | Formação Java
http://cursos.triadworks.com.br

[lucascs]

is there any difference between javax.el-api and el-api?

[garcia-jj]

javax.el:el-api is 2.0 maintenance release. javax.el:javax.el-api is 3.0 release.

[garcia-jj]

LinkTo feature can be tested using this approach.

[Turini]

LinkTo feature can be tested using this approach.

this is very nice!

[renanigt]

This test is breaking when call new ELProcessor():

vraptor4/vraptor-core/src/test/java/br/com/caelum/vraptor/validator/MessagesTest.java

Line 96 in 73a367d

public void testElExpressionGettingMessagesByCaegory() {

[garcia-jj]

Works fine to me, runing tests right now. Have you with your workspace up2date with new maven dependencies, introduced by this pull request?

[renanigt]

Yes @garcia-jj, my workspace is up-to-date with new maven dependencies.

Someone may also test it ?

The error is:

java.lang.NoSuchMethodError: javax.el.ELUtil.getExpressionFactory()Ljavax/el/ExpressionFactory;
    at javax.el.ELManager.getExpressionFactory(ELManager.java:61)
    at javax.el.ELProcessor.<init>(ELProcessor.java:99)
    at br.com.caelum.vraptor.validator.MessagesTest.testElExpressionGettingMessagesByCaegory(MessagesTest.java:101)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

[garcia-jj]

Travis runs ok right now: https://travis-ci.org/caelum/vraptor4/builds/34151368

[renanigt]

I don't know why this happening here at home and also on work.
But I'll do another tests.

Thanks @garcia-jj

[garcia-jj]

What's happens if you run using command line?

[renanigt]

Running it using command line the MessagesTest works fine, breaking just these tests:

shouldNotRunVRaptorStackIfVRaptorRequestStartedEventNotFired(br.com.caelum.vraptor.ioc.RequestStartedFactoryTest): WELD-001303: No active contexts for scope type javax.enterprise.context.RequestScoped
shouldRunVRaptorStackIfVRaptorRequestStartedEventIsFired(br.com.caelum.vraptor.ioc.RequestStartedFactoryTest): WELD-001303: No active contexts for scope type javax.enterprise.context.RequestScoped
shoudRegisterResourcesInRouter(br.com.caelum.vraptor.ioc.cdi.CDIBasedContainerTest): You shouldn't add more interceptors after ordering. Please notify vraptor developers.
shouldReturnAllDefaultConverters(br.com.caelum.vraptor.ioc.cdi.CDIBasedContainerTest): You shouldn't add more interceptors after ordering. Please notify vraptor developers.
shouldReturnAllDefaultDeserializers(br.com.caelum.vraptor.ioc.cdi.CDIBasedContainerTest): You shouldn't add more interceptors after ordering. Please notify vraptor developers.
shoudRegisterConvertersInConverters(br.com.caelum.vraptor.ioc.cdi.CDIBasedContainerTest): You shouldn't add more interceptors after ordering. Please notify vraptor developers.
shoudRegisterInterceptorsInInterceptorRegistry(br.com.caelum.vraptor.ioc.cdi.CDIBasedContainerTest): You shouldn't add more interceptors after ordering. Please notify vraptor developers.