Organizing Maven dependencies #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With comments to help users to check if some dependency can be removed in their applications.
| @@ -133,19 +143,6 @@ | |||
| <scope>provided</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
Removed because is part of Java EE 6.
garcia-jj
added a commit
that referenced
this pull request
Nov 17, 2014
Organizing Maven dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With comments to help users to check if some dependency can be removed in their applications.
Questions:
Why
javax.inject:javax.injectis provided butjavax.annotation:javax.annotation-apiisn't? Both are provided by appserver but no by servlet containers. The same forjavax.interceptor:javax.interceptor-apiandjavax.ejb:javax.ejb-api. The default dependencies should focused in appserver or servlet containers?Why
org.hibernate:hibernate-validator-cdiis provided? May be this artifact should only test scoped, because we need to use in tests. Or if our focus is on servlet containers should compile.