Add types for Node.predecessor(), Tree._clone(), Tree.subtree() and Tree.to_dict() #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-law
commented
Mar 4, 2025
| @@ -118,7 +118,7 @@ def _clone( | |||
| identifier: Optional[str] = None, | |||
| with_tree: bool = False, | |||
| deep: bool = False, | |||
| ): | |||
| ) -> "Tree": | |||
There was a problem hiding this comment.
I would normally use -> Tree here and import __future__.annotations but I'm not sure if that's supported by all versions of Python that treelib supports, so this felt a little bit safer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @caesar0301, following #232 I found some functions that I use in treelib which were left untyped, so I added type annotations to them.
Hopefully these are correct and it helps. I ran
scripts/flake8.shand no issues were flagged, but there isn't coverage around the actual typing itself.