Skip to content
This repository was archived by the owner on Sep 2, 2020. It is now read-only.

update operators from pytorch #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wenwei202
Copy link

@wenwei202
Copy link
Author

wenwei202 commented Aug 23, 2018

@orionr Could you review? D9472991

@orionr
Copy link
Contributor

orionr commented Aug 23, 2018

Unfortunately it looks like our new PyTorch-style docstrings don't convert well to the caffe2.ai operator catalog. @JoelMarcey @ericnakagawa and @caabernathy any interest in trying to get this fixed by stripping formatting, etc? Let's also talk to Matt, Nate, and Winston in our tech writer meeting. Not required for the PyTorch 1.0 release, but would be great to make this functional again.

@JoelMarcey
Copy link
Contributor

@orionr Hey! Yeah, I can discuss this with you/others and have a look at this.

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@JoelMarcey
Copy link
Contributor

@orionr - 👋 Hi. Is this still an issue for the new site?

@orionr
Copy link
Contributor

orionr commented Sep 21, 2018

It actually is. We don't have the Caffe2 APIs on the pytorch.org site (we decided to keep them separate and on caffe2.ai) so we do need to ultimately get these updated. Unfortunately I do see some issue with the formatting once this is applied, so it would be great if we could work together on getting the automatic doc generation code running again. In this case @wenwei202 needed to run things manually.

@JoelMarcey
Copy link
Contributor

@orionr Sounds good. Maybe this is something we can talk about at our docs standup this week?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants