Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made redirect URLs keep query params #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdunster
Copy link

@sdunster sdunster commented May 2, 2014

This commit makes the redirect back to the client app maintain the query arguments that were passed with the original authorise. This is required for a number of apps including the Meteor accounts packages (http://github.com/uowits/meteor-accounts-uow).

The OAuth2 RFC says that OAuth2 providers MUST implement this functionality.
http://tools.ietf.org/html/rfc6749#section-3.1.2

The redirection endpoint URI MUST be an absolute URI as defined by
[RFC3986] Section 4.3. The endpoint URI MAY include an
"application/x-www-form-urlencoded" formatted (per Appendix B) query
component ([RFC3986] Section 3.4), which MUST be retained when adding
additional query parameters. The endpoint URI MUST NOT include a
fragment component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant